KurtYoung commented on a change in pull request #10105:
[Flink-14599][table-planner-blink] Support precision of TimestampType in blink
planner
URL: https://github.com/apache/flink/pull/10105#discussion_r343565799
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/GenerateUtils.scala
##########
@@ -455,13 +465,15 @@ object GenerateUtils {
def generateRowtimeAccess(
ctx: CodeGeneratorContext,
contextTerm: String): GeneratedExpression = {
+ val resultType = new TimestampType(true, TimestampKind.ROWTIME, 3)
Review comment:
If user declares a field with TIMESTAMP(9) and tells framework that field is
row time attribute, we still have to support it, right?
For proctime, since it's generated by framework, I'm ok with treating it as
TIMESTAMP(3)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
