eskabetxe commented on a change in pull request #9533: [FLINK-13850]
[Connectors / FileSystem] Refactor part file configuration into a single method
URL: https://github.com/apache/flink/pull/9533#discussion_r343587912
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/filesystem/PartFileConfig.java
##########
@@ -18,36 +18,81 @@
package org.apache.flink.streaming.api.functions.sink.filesystem;
+import org.apache.flink.annotation.PublicEvolving;
import org.apache.flink.util.Preconditions;
+import java.io.Serializable;
+
/**
* Part file name configuration.
* This allow to define a prefix and a suffix to the part file name.
*/
-class PartFileConfig {
-
- public static final String DEFAULT_PART_PREFIX = "part";
-
- public static final String DEFAULT_PART_SUFFIX = "";
+public class PartFileConfig implements Serializable {
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
