JingsongLi commented on a change in pull request #10119: [FLINK-14656]
[table-planner-blink] blink planner should also fetch catalog statistics for
permanent CatalogTableImpl
URL: https://github.com/apache/flink/pull/10119#discussion_r343963712
##########
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/catalog/DatabaseCalciteSchema.java
##########
@@ -136,7 +136,7 @@ private Table convertTemporaryTable(
return convertSinkTable(connectorTable);
}
} else if (table instanceof CatalogTable) {
- return convertCatalogTable(tablePath, (CatalogTable)
table, null);
+ return convertCatalogTable(tablePath, (CatalogTable)
table, null, TableStats.UNKNOWN);
Review comment:
Here if we take a look to `extractTableStats`. It gets stats from catalog. I
think `ConnectorCatalogTable` should never be put into catalog.
So I think we need remove `extractTableStats` of `ConnectorCatalogTable`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
