danny0405 opened a new pull request #10123: [FLINK-14386][table-planner-blink] Support computed column for create… URL: https://github.com/apache/flink/pull/10123 … table statement ## What is the purpose of the change This patch add support for end-to-end computed column for create table statement in table-planner-blink. Note that we does not support referencing UDFs from external catalog now for this path, it is expected to implement in FLINK-14664. ## Brief change log - Define a new interface named `FlinkToRelContext` used to hold the variables for converting schema table to a relational expression - Make `FlinkPlannerImpl` extend `FlinkToRelContext`, the `FlinkPlannerImpl` is used to convert table and expanding view now. Instead of hold a `ViewExpander` instance, `FlinkPlannerImpl` itself is a `ViewExpander` now - Define a new interface named `CalciteCatalogTable`, which is the type that we fetch table from the catalog. We then translate it lazy in `FlinkRelOptTable` to `TableSourceTable` or `TableSinkTable` - In `FlinkRelOptTable#toRel`, add logic to append computed columns to the table ## Verifying this change See tests in `CatalogTableITCase` and `ComputedColumnToRelTest`. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no - The serializers: no - The runtime per-record code paths (performance sensitive): no - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no - The S3 file system connector: no ## Documentation - Does this pull request introduce a new feature? yes - If yes, how is the feature documented? JavaDocs / not documented
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
