KurtYoung commented on a change in pull request #10022: [FLINK-14135][orc] 
Introduce OrcColumnarRowInputFormat
URL: https://github.com/apache/flink/pull/10022#discussion_r344023554
 
 

 ##########
 File path: 
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveTableSource.java
 ##########
 @@ -100,11 +98,12 @@ private HiveTableSource(JobConf jobConf, ObjectPath 
tablePath, CatalogTable cata
        }
 
        @Override
-       public InputFormat getInputFormat() {
+       public InputFormat<BaseRow, ?> getInputFormat() {
                if (!initAllPartitions) {
                        initAllPartitions();
                }
-               return new HiveTableInputFormat(jobConf, catalogTable, 
allHivePartitions, projectedFields);
+               return InputFormatUtil.createInputFormat(
 
 Review comment:
   `InputFormatUtil` is only used here, no necessary to introduce a util class. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to