tillrohrmann commented on a change in pull request #10120: [FLINK-14646] Check
non-null for key in KeyGroupStreamPartitioner
URL: https://github.com/apache/flink/pull/10120#discussion_r344090524
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/state/KeyGroupRangeAssignment.java
##########
@@ -45,7 +47,8 @@ private KeyGroupRangeAssignment() {
* @param parallelism the current parallelism of the operator
* @return the index of the parallel operator to which the given key
should be routed.
*/
- public static int assignKeyToParallelOperator(Object key, int
maxParallelism, int parallelism) {
+ public static int assignKeyToParallelOperator(@Nullable Object key, int
maxParallelism, int parallelism) {
Review comment:
We should only annotate fields/parameters with `@Nullable` if we allow them
to be `null`. This is here not the case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
