lamber-ken edited a comment on issue #6075: [FLINK-9407] [hdfs connector] Support orc rolling sink writer URL: https://github.com/apache/flink/pull/6075#issuecomment-551488915 > Thanks @hequn8128. You are very correct! It is more reasonable to put the ORC related classes into there ~, like @StephanEwen said, at the very least. make them optional. > > As refers to implement the `CheckpointedFuntion`, I would not think it is necessary for it since `BucketingSink` have already implemented that and we just use the orc writer in this way like `bucketingSink.setWriter(new OrcFileWriter<>(orcSchema))`.Also, we can take a look on `SequenceFileWriter` and `StringWriter` both do not implement `CheckpointedFuntion`. hi, @hequn8128, what about `writer.writeIntermediateFooter();`?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
