xuyang1706 commented on issue #9373: [FLINK-13596][ml] Add two utils for Table transformations URL: https://github.com/apache/flink/pull/9373#issuecomment-551506390 > Hi @xuyang1706 thanks for the update. I just did another pass and find that some of the branches are missing test cases; also I think the various APIs in the utilities seems a bit hard to understand and I was not sure which of these APIs are considered to be general usage and which are less utilized. > Please kindly take a look (I only comment on the DataSet side since DataStream side is similar). Thanks for your comments @walterddr . I have added some test cases for both DataSet and DataStream sides. Flink can detect the type of the column when the DataSet carry the type information, thus in most cases we can use the simple API, but for some bad cases, we have to input the column type information. Thanks --Xu
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
