dawidwys commented on a change in pull request #10118: [FLINK-14657] Generalize and move config utils from flink-yarn to flink-core URL: https://github.com/apache/flink/pull/10118#discussion_r344141721
########## File path: flink-core/src/main/java/org/apache/flink/configuration/ConfigUtils.java ########## @@ -0,0 +1,114 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.configuration; + +import org.apache.flink.annotation.Internal; + +import java.util.Arrays; +import java.util.Collections; +import java.util.List; +import java.util.Objects; +import java.util.function.Function; +import java.util.stream.Collectors; +import java.util.stream.Stream; + +import static org.apache.flink.util.Preconditions.checkNotNull; + +/** + * General utilities for parsing values to configuration options. + */ +@Internal +public class ConfigUtils { + + /** + * Puts an array of values of type {@code IN} in a {@link Configuration} + * as a {@link ConfigOption} of type {@link List} of type {@code OUT}. + * + * @param configuration the configuration object to put the list in + * @param key the {@link ConfigOption option} to serve as the key for the list in the configuration + * @param value the array of values to put as value for the {@code key} + * @param mapper the transformation function from {@code IN} to {@code OUT}. + */ + public static <IN, OUT> void encodeArrayToConfig( + final Configuration configuration, Review comment: Can we use `WritableConfig` here? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
