carp84 commented on a change in pull request #9516: [FLINK-13815][State Backends] Implement the SpaceAllocator URL: https://github.com/apache/flink/pull/9516#discussion_r344499365
########## File path: flink-state-backends/flink-statebackend-heap-spillable/src/main/java/org/apache/flink/runtime/state/heap/space/CleanerUtil.java ########## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.state.heap.space; + +import java.io.IOException; +import java.lang.invoke.MethodHandle; +import java.lang.invoke.MethodHandles; +import java.lang.reflect.Field; +import java.lang.reflect.Method; +import java.nio.ByteBuffer; +import java.security.AccessController; +import java.security.PrivilegedAction; +import java.util.Objects; + +import static java.lang.invoke.MethodHandles.constant; +import static java.lang.invoke.MethodHandles.dropArguments; +import static java.lang.invoke.MethodHandles.filterReturnValue; +import static java.lang.invoke.MethodHandles.guardWithTest; +import static java.lang.invoke.MethodType.methodType; + +/** + * Direct buffer cleaner tool, mainly copied from Hadoop project (see org.apache.hadoop.util.CleanerUtil). + * + * <p/>sun.misc.Cleaner has moved in OpenJDK 9 and + * sun.misc.Unsafe#invokeCleaner(ByteBuffer) is the replacement. + * This class is a hack to use sun.misc.Cleaner in Java 8 and + * use the replacement in Java 9+. + * This implementation is inspired by LUCENE-6989. + */ +final class CleanerUtil { Review comment: Yes, there were some more clean up work to do after #9501 and this is fixed in the updated commit. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
