zhijiangW commented on a change in pull request #10083:
[FLINK-14472][runtime]Implement back-pressure monitor with non-blocking outputs.
URL: https://github.com/apache/flink/pull/10083#discussion_r344538921
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/backpressure/BackPressureStats.java
##########
@@ -38,26 +40,21 @@
/** Time stamp, when the request was triggered. */
private final long startTime;
- /** Time stamp, when all back pressure stats were collected at the
JobManager. */
+ /** Time stamp, when all back pressure stats were collected at the
BackPressureRequestCoordinator. */
private final long endTime;
- /** Map of back pressure ratio by execution ID. */
+ /** Map of back pressure ratios by execution ID. */
private final Map<ExecutionAttemptID, Double> backPressureRatios;
public BackPressureStats(
- int requestId,
- long startTime,
- long endTime,
+ @Nonnegative int requestId,
+ @Nonnegative long startTime,
+ @Nonnegative long endTime,
Map<ExecutionAttemptID, Double> backPressureRatios) {
-
- checkArgument(requestId >= 0, "Negative request ID.");
- checkArgument(startTime >= 0, "Negative start time.");
- checkArgument(endTime >= startTime, "End time before start
time.");
Review comment:
Keep this check?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
