TisonKun commented on a change in pull request #10074: [FLINK-14499][Runtime /
Metrics]MetricRegistry#getMetricQueryServiceGatewayRpcAddress is Nonnull
URL: https://github.com/apache/flink/pull/10074#discussion_r344602603
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorTest.java
##########
@@ -187,7 +187,7 @@
private static final Time timeout = Time.milliseconds(10000L);
- private String metricQueryServiceAddress;
Review comment:
Why do you remove this variable? Is there any objection to retain this
variable, just move metricRegistry a field, and close it after method? I think
most of line add to get metricQueryServiceAddress below can be reduced.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
