AT-Fieldless commented on a change in pull request #10074:
[FLINK-14499][Runtime /
Metrics]MetricRegistry#getMetricQueryServiceGatewayRpcAddress is Nonnull
URL: https://github.com/apache/flink/pull/10074#discussion_r344631801
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorSubmissionTest.java
##########
@@ -105,30 +105,35 @@
private JobID jobId = new JobID();
- private String metricQueryServiceAddress;
Review comment:
At that time, I found many duplicate code like `final ExecutionAttemptID
eid1 = new ExecutionAttemptID();` in this file, so I think in each test, there
should also be a unique "metricQueryServiceAddress". But actually,
"metricQueryServiceAddress" is same because of "metricRegistry" is same, so it
can be retained?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
