mxm commented on a change in pull request #10153: [FLINK-14709] Allow
outputting elements in user defined close method,…
URL: https://github.com/apache/flink/pull/10153#discussion_r344796670
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/DataSourceTask.java
##########
@@ -208,12 +208,11 @@ public void invoke() throws Exception {
completedSplitsCounter.inc();
} // end for all input splits
- // close the collector. if it is a chaining task
collector, it will close its chained tasks
- this.output.close();
-
// close all chained tasks letting them report failure
BatchTask.closeChainedTasks(this.chainedTasks, this);
+ // close the output collector
+ this.output.close();
Review comment:
+1 I think this order makes more sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
