TisonKun commented on a change in pull request #10104: [FLINK-14629][client]
Refactor ScalaShellRemote(Stream)Environment to simplify inheritance
URL: https://github.com/apache/flink/pull/10104#discussion_r344983911
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/RemoteStreamEnvironment.java
##########
@@ -192,138 +159,46 @@ public RemoteStreamEnvironment(String host, int port,
Configuration clientConfig
try {
URL jarFileUrl = new
File(jarFile).getAbsoluteFile().toURI().toURL();
this.jarFiles.add(jarFileUrl);
- ClientUtils.checkJarFile(jarFileUrl);
+ JarUtils.checkJarFile(jarFileUrl);
} catch (MalformedURLException e) {
throw new IllegalArgumentException("JAR file
path is invalid '" + jarFile + "'", e);
} catch (IOException e) {
throw new RuntimeException("Problem with jar
file " + jarFile, e);
}
}
+
if (globalClasspaths == null) {
this.globalClasspaths = Collections.emptyList();
- }
- else {
+ } else {
this.globalClasspaths = Arrays.asList(globalClasspaths);
}
- this.savepointRestoreSettings = savepointRestoreSettings;
- }
- /**
Review comment:
Do you ask for doing so in a separate story?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
