wangyang0918 commented on a change in pull request #10084: [FLINK-14382][yarn]
Incorrect handling of FLINK_PLUGINS_DIR on Yarn
URL: https://github.com/apache/flink/pull/10084#discussion_r345116959
##########
File path:
flink-java/src/main/java/org/apache/flink/api/java/utils/ParameterTool.java
##########
@@ -91,22 +94,23 @@ public static ParameterTool fromArgs(String[] args) {
i += 1; // try to find the value
+ map.putIfAbsent(key, new ArrayList<>());
Review comment:
I will try to add a new `MultipleParameterTool extends ParameterTool`
instead. It is an enhanced class with multiple parameters support. And it will
be marked as `PublicEvolving`. It should be compatible with `ParameterTool`,
all the tests of `ParameterToolTest` should pass.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
