[
https://issues.apache.org/jira/browse/FLINK-14716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16972282#comment-16972282
]
Jark Wu commented on FLINK-14716:
---------------------------------
Thanks [~danny0405] for looking into this. I think {{TableSourceTable}}
definitely shouldn't return virtual columns as it doesn't produce the virtual
columns.
Yes, we may need another {{Table}} abstraction to wrap virtual columns.
> Cooperate computed column with project push down
> ------------------------------------------------
>
> Key: FLINK-14716
> URL: https://issues.apache.org/jira/browse/FLINK-14716
> Project: Flink
> Issue Type: Sub-task
> Components: Table SQL / Planner
> Reporter: Jark Wu
> Priority: Major
>
> In FLINK-14665, we supported computed column in planner. However, the
> implementation of {{TableSourceTable#getRowType}} will include computed
> columns which is possibly not right, because computed column is generated in
> the downstream Project, not in the source scan.
> This is possibly lead to errors when push project into source scan which will
> call {{TableSourceTable#getRowType}} in the rule. Currently, all the tests
> are passed because we don't have a test to cover this, i.e. computed column
> on a projectable TableSource. We should at least add a test to cover this.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
