godfreyhe opened a new pull request #10163: [FLINK-14724] [table-planner-blink] Join condition could be simplified in logical phase URL: https://github.com/apache/flink/pull/10163 ## What is the purpose of the change *the plan of tpcds q38.sql contains NestedLoopJoin, because it's join condition is CAST(AND(IS NOT DISTINCT FROM($2, $3), IS NOT DISTINCT FROM($1, $4), IS NOT DISTINCT FROM($0, $5))):BOOLEAN, and planner can't find equal join keys from the condition by Join#analyzeCondition. add SimplifyJoinConditionRule into logical phase to simplify join condition* ## Brief change log - *add SimplifyJoinConditionRule into logical phase to simplify join condition for batch and stream program* ## Verifying this change This change added tests and can be verified as follows: - *Added test that validates the plan from sql like tpcds-q38.sql in SetOperatorsTest* ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / **no)** - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no)** - The serializers: (yes / **no** / don't know) - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know) - The S3 file system connector: (yes / **no** / don't know) ## Documentation - Does this pull request introduce a new feature? (yes / **no)** - If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
