GJL commented on a change in pull request #10152: [FLINK-14466][runtime] Let
YarnJobClusterEntrypoint use user code class loader
URL: https://github.com/apache/flink/pull/10152#discussion_r345327521
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/entrypoint/component/FileJobGraphRetriever.java
##########
@@ -55,16 +62,28 @@ public JobGraph retrieveJobGraph(Configuration
configuration) throws FlinkExcept
try (FileInputStream input = new FileInputStream(fp);
ObjectInputStream obInput = new
ObjectInputStream(input)) {
+ final JobGraph jobGraph = (JobGraph)
obInput.readObject();
- return (JobGraph) obInput.readObject();
+ final List<URL> userClassPaths = new ArrayList<>();
Review comment:
I think it would look better if we extract the logic to set the class path
into a separate method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
