dawidwys commented on a change in pull request #10160:
[FLINK-14723][table-planner-blink] Improve some code of computed column in
planner
URL: https://github.com/apache/flink/pull/10160#discussion_r345333491
##########
File path:
flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/table/operations/JavaDataStreamQueryOperation.java
##########
@@ -38,6 +38,11 @@
@Internal
public class JavaDataStreamQueryOperation<E> implements QueryOperation {
+ // JavaDataStreamQueryOperation represent a registered DataStream from
`registerDataStream` method
+ // or a unregistered DataStream from `fromDataStream`. However the name
under which the DataStream
+ // is registered is missing when converting a
JavaDataStreamQueryOperation to a RelNode.
+ // So using `qualifiedName` to keep the original name.
+ private List<String> qualifiedName;
Review comment:
Can we use ObjectIdentifier here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
