bowenli86 commented on a change in pull request #10157: [FLINK-14710][hive]
Decide column nullability according to Hive const…
URL: https://github.com/apache/flink/pull/10157#discussion_r345466087
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/client/HiveMetastoreClientWrapper.java
##########
@@ -210,6 +212,11 @@ public boolean
updatePartitionColumnStatistics(ColumnStatistics columnStatistics
//-------- Start of shimmed methods ----------
+ public Set<String> getNotNullColumns(Configuration conf, String dbName,
String tableName) {
+ HiveShim hiveShim = HiveShimLoader.loadHiveShim(hiveVersion);
Review comment:
no need to create a HiveShim instance every time. HiveMetastoreClientWrapper
can just keep a HiveShim instance built in constructor?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
