lirui-apache commented on a change in pull request #10157: [FLINK-14710][hive]
Decide column nullability according to Hive const…
URL: https://github.com/apache/flink/pull/10157#discussion_r345564433
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/client/HiveShimV310.java
##########
@@ -111,4 +112,28 @@ public void makeSpecFromName(Map<String, String>
partSpec, Path currPath) {
}
}
+ @Override
+ public Set<String> getNotNullColumns(IMetaStoreClient client,
Configuration conf, String dbName, String tableName) {
+ try {
+ Method method =
getMetaStoreUtilsClass().getDeclaredMethod("getDefaultCatalog",
Configuration.class);
Review comment:
Firstly to clarify, here the "default catalog" refers to the default catalog
in HMS, not in Flink.
[HIVE-18685](https://issues.apache.org/jira/browse/HIVE-18685) is to introduce
catalog to HMS. Since that feature is not yet completed, it's fine to just use
`getDefaultCatalog `. After HIVE-18685 is done, we may need to take HMS catalog
into consideration when interacting with Hive metadata.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
