wuchong commented on a change in pull request #10160: 
[FLINK-14723][table-planner-blink] Improve some code of computed column in 
planner
URL: https://github.com/apache/flink/pull/10160#discussion_r345564445
 
 

 ##########
 File path: 
flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/table/operations/JavaDataStreamQueryOperation.java
 ##########
 @@ -38,6 +38,11 @@
 @Internal
 public class JavaDataStreamQueryOperation<E> implements QueryOperation {
 
+       // JavaDataStreamQueryOperation represent a registered DataStream from 
`registerDataStream` method
 
 Review comment:
   I think it explains clearly why we have this field in it (we don't have this 
information when initialization but pass in when converting to RelNode). 
   
   But I'm also fine to remove this. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to