JingsongLi commented on a change in pull request #10157: [FLINK-14710][hive]
Decide column nullability according to Hive const…
URL: https://github.com/apache/flink/pull/10157#discussion_r345574501
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/client/HiveShimV310.java
##########
@@ -111,4 +112,28 @@ public void makeSpecFromName(Map<String, String>
partSpec, Path currPath) {
}
}
+ @Override
+ public Set<String> getNotNullColumns(IMetaStoreClient client,
Configuration conf, String dbName, String tableName) {
+ try {
+ Method method =
getMetaStoreUtilsClass().getDeclaredMethod("getDefaultCatalog",
Configuration.class);
Review comment:
Can you add these comments to code?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
