zhijiangW commented on a change in pull request #10083:
[FLINK-14472][runtime]Implement back-pressure monitor with non-blocking outputs.
URL: https://github.com/apache/flink/pull/10083#discussion_r345654926
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/legacy/backpressure/BackPressureRequestCoordinatorTest.java
##########
@@ -262,9 +274,9 @@ public TestingExecutionVertex(
Runnable::run,
this,
0,
- 1L,
- System.currentTimeMillis(),
- Time.seconds(10),
+ initialGlobalModVersion,
+ createTimestamp,
+ timeout,
Review comment:
We could further remove `maxPriorExecutionHistoryLength` and
`producedDataSets` arguments at least from the constructor because they can be
initialized here when needed. No need to pass it from above
`createExecutionVertex` to make all the relevant method arguments long.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
