[
https://issues.apache.org/jira/browse/FLINK-2591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14973986#comment-14973986
]
ASF GitHub Bot commented on FLINK-2591:
---------------------------------------
Github user willmiao commented on the pull request:
https://github.com/apache/flink/pull/1121#issuecomment-151092573
hi @rmetzger ,
I believe I find the reason why my test failed.
A test will fail if we don’t specify “-t” argument(_which is an optional
argument_) in the command when call runWithArgs function, and we will get
exception here:
```
Exception in thread "main" java.lang.NoClassDefFoundError:
org/apache/log4j/Level
at org.apache.hadoop.mapred.JobConf.<clinit>(JobConf.java:357)
```
It seems some jar files relevant to log callback are needed.
One more thing, I noticed a segment of code as follows in the file
“FlinkYarnSessionCli.java”:
```
File logback = new File(confDirPath + File.pathSeparator +
CONFIG_FILE_LOGBACK_NAME);
if (logback.exists()) {
shipFiles.add(logback);
flinkYarnClient.setFlinkLoggingConfigurationPath(new
Path(logback.toURI()));
}
```
And I wonder if “**File.pathSeparator**” should be “**File.separator**”
here.
> Add configuration parameter for default number of yarn containers
> -----------------------------------------------------------------
>
> Key: FLINK-2591
> URL: https://issues.apache.org/jira/browse/FLINK-2591
> Project: Flink
> Issue Type: Improvement
> Components: YARN Client
> Reporter: Robert Metzger
> Assignee: Will Miao
> Priority: Minor
> Labels: starter
>
> A user complained about the requirement to always specify the number of yarn
> containers (-n) when starting a job.
> Adding a configuration value with a default value will allow users to set a
> default ;)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
