zentol commented on a change in pull request #10106: [FLINK-11463][e2e] Design
the e2e java framework so that at least the Kafka streaming tests can run on it
URL: https://github.com/apache/flink/pull/10106#discussion_r345772897
##########
File path: flink-end-to-end-tests/pom.xml
##########
@@ -97,6 +101,27 @@ under the License.
<id>integration-tests</id>
<phase>none</phase>
</execution>
+ <execution>
+ <id>end-to-end-tests</id>
+ <phase>integration-test</phase>
+ <goals>
+ <goal>test</goal>
+ </goals>
+ <configuration>
+ <includes>
+
<include>**/*ITCase.*</include>
+ </includes>
+ <!-- Disable all tests
by default.
+ Uses a separate property to make it
configurable from the command-line. -->
+
<groups>${includeE2E}</groups>
+
<excludedGroups>${excludeE2E}</excludedGroups>
+ <!-- E2E tests must not
access flink-dist concurrently. -->
+ <forkCount>1</forkCount>
+
<systemPropertyVariables>
+
<moduleDir>${project.basedir}/..</moduleDir>
Review comment:
this doesn't look correct; with this in place we'd be searching for jars in
`flink-end-to-end-tests`; we only want to search in the respective module that
contains the test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
