Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1097#issuecomment-151142957
Going through FLINK-2017, I interpreted the semantics of `check` and
`checkAndPopulate` as follows:
- `check` verifies that all required parameters are provided and valid
(type, choice, etc.)
- `checkAndPopulate` copied the default values of the options into the
`ParameterTool`
I think a method that is called `checkAndPopulate` should perform the same
checks as `check` and do the *populate* in addition. Moreover, I do not see why
`check` alone would be useful. Why would somebody define required parameters
with default values without enforcing them, i.e., why you call `check` without
`checkAndPopulate`.
If we have a single method, we could also give it a simpler name such as
`applyTo`.
What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
