zoudaokoulife commented on a change in pull request #10184: [FLINK-14481]Modify
the Flink valid socket port check to 0 to 65535.
URL: https://github.com/apache/flink/pull/10184#discussion_r346109273
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestClient.java
##########
@@ -229,7 +229,7 @@ public void shutdown(Time timeout) {
Collection<FileUpload> fileUploads,
RestAPIVersion apiVersion) throws IOException {
Preconditions.checkNotNull(targetAddress);
- Preconditions.checkArgument(0 <= targetPort && targetPort <
65536, "The target port " + targetPort + " is not in the range (0, 65536].");
+ Preconditions.checkArgument(0 <= targetPort && targetPort <
65536, "The target port " + targetPort + " is not in the range [0, 65536).");
Review comment:
why not do it as precode, eg:
Preconditions.checkArgument(0 <= targetPort && targetPort <=
65535, "The target port " + targetPort + " is not in the range [0, 65535].");
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
