link3280 commented on issue #10113: [FLINK-13749][client] Make PackagedProgram 
respect classloading policy
URL: https://github.com/apache/flink/pull/10113#issuecomment-553777290
 
 
   Thanks a lot for your detailed review @NicoK ! The comments are addressed.
   
   Agreed with the `configuration` issue. It's more user-friendly and concise 
to pass `configuration` instead of the concrete options.
   
   Regarding the regression problem, I'm not sure I fully understand the 
situation. Does the old code mean a previous commit in this PR? If yes, it 
should be fixed already.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to