dawidwys commented on a change in pull request #10194: [FLINK-14758] Add
Executor-related interfaces and executor discovery.
URL: https://github.com/apache/flink/pull/10194#discussion_r346333754
##########
File path:
flink-java/src/main/java/org/apache/flink/api/java/ExecutionEnvironment.java
##########
@@ -122,11 +128,28 @@
/** Flag to indicate whether sinks have been cleared in previous
executions. */
private boolean wasExecuted = false;
+ private final ExecutorServiceLoader executorServiceLoader;
+
+ private final Configuration configuration;
+
/**
* Creates a new Execution Environment.
*/
protected ExecutionEnvironment() {
+ this(new Configuration());
+ }
+
+ protected ExecutionEnvironment(final Configuration
executorConfiguration) {
+ this(new DefaultExecutorServiceLoader(), executorConfiguration);
+ }
+ protected ExecutionEnvironment(final ExecutorServiceLoader
executorServiceLoader, final Configuration executorConfiguration) {
+ this.executorServiceLoader =
checkNotNull(executorServiceLoader);
+ this.configuration = checkNotNull(executorConfiguration);
+ }
+
+ protected Configuration getConfiguration() {
Review comment:
What do we need this method for?
I tried to find usages of it, but can't find any.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
