aljoscha commented on issue #10005: [FLINK-14533][flink-table-planner] Fix LOWER/UPPER not being pushed down to TableSource URL: https://github.com/apache/flink/pull/10005#issuecomment-553987802 @YuvalItzchakov Can you confirm that your newly added test actually works on your branch? I think something might have changed after you implemented it but I'm wondering why it ever worked. This seems very strange to me. 😅 The test fails because your tests (before translation) expect ``` LogicalProject(a=[$0], b=[$1]) +- LogicalFilter(condition=[LIKE(LOWER($0), _UTF-16LE'foo')]) +- LogicalTableScan(table=[[default_catalog, default_database, MTable]]) ``` but it is ``` LogicalProject(a=[$0], b=[$1]) +- LogicalFilter(condition=[LIKE(LOWER($0), _UTF-16LE'foo')]) +- LogicalTableScan(table=[[default_catalog, default_database, MTable, source: [filterPushedDown=[false], filter=[]]]]) ``` the `filterPushedDown` part is a newer addition. When I fix that, your tests fail because `shouldPushDown` doesn't return true because the top-level call is a `like`, and not a `lower`.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
