KurtYoung commented on a change in pull request #10196: [FLINK-14789]
[table-planner-blink] extends max/min type in ColumnStats from Number to
Comparable
URL: https://github.com/apache/flink/pull/10196#discussion_r346688196
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/plan/stats/ColumnStats.java
##########
@@ -50,22 +50,22 @@
private final Integer maxLen;
/**
- * max value of column values.
+ * max value of column values, null for none-comparable type.
*/
- private final Number max;
+ private final Comparable<?> max;
/**
- * min value of column values.
+ * min value of column values, null for none-comparable type.
*/
- private final Number min;
+ private final Comparable<?> min;
public ColumnStats(
Long ndv,
Long nullCount,
Double avgLen,
Integer maxLen,
- Number max,
- Number min) {
+ Comparable<?> max,
Review comment:
This is API breaking change, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
