azagrebin commented on a change in pull request #10180: [FLINK-14631] Account
for netty direct allocations in direct memory limit (Netty Shuffle)
URL: https://github.com/apache/flink/pull/10180#discussion_r346707706
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/NettyShuffleEnvironmentOptions.java
##########
@@ -175,7 +175,8 @@
public static final ConfigOption<Integer> NUM_ARENAS =
key("taskmanager.network.netty.num-arenas")
- .defaultValue(-1)
+ .intType()
Review comment:
this adds an option class explicitly, `ConfigOption<Integer>` is typed only
during compilation. From what I see, `defaultValue()` for an untyped option has
been deprecated. The details in FLIP-77.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
