aljoscha commented on a change in pull request #8914: [FLINK-12929] Pass
TypeInformation in addSource
URL: https://github.com/apache/flink/pull/8914#discussion_r346735477
##########
File path:
flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/StreamExecutionEnvironment.scala
##########
@@ -615,7 +615,7 @@ class StreamExecutionEnvironment(javaEnv: JavaEnv) {
val cleanFun = scalaClean(function)
val typeInfo = implicitly[TypeInformation[T]]
- asScalaStream(javaEnv.addSource(cleanFun).returns(typeInfo))
+ asScalaStream(javaEnv.addSource(cleanFun, typeInfo))
Review comment:
This change should actually still set the output type because we now pass
the type directly in the function call which also sets it on the transformer?
Could you maybe step through the code using a debugger and see if (or why not)
the output type is set or not set.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
