TisonKun commented on a change in pull request #10193: [FLINK-13938][yarn] Use
pre-uploaded flink binary to accelerate flink submission
URL: https://github.com/apache/flink/pull/10193#discussion_r346813601
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/Utils.java
##########
@@ -149,61 +155,79 @@ public static void setupYarnClassPath(Configuration
conf, Map<String, String> ap
String appId,
Path localSrcPath,
Path homedir,
- String relativeTargetPath) throws IOException {
-
- File localFile = new File(localSrcPath.toUri().getPath());
- if (localFile.isDirectory()) {
- throw new IllegalArgumentException("File to copy must
not be a directory: " +
- localSrcPath);
- }
+ String relativeTargetPath,
+ @Nullable FileStatus preUploadedFileStatus) throws IOException {
Review comment:
It seems that you don't push the commit so far. One reminder is for smooth
review you can push the change in another commit :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
