zentol commented on a change in pull request #10216:
[FLINK-14750][configuration] Migrate duration and memory size ConfigOptions in
RestartStrategyOptions
URL: https://github.com/apache/flink/pull/10216#discussion_r346833560
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/restart/RestartStrategyFactoryTest.java
##########
@@ -61,7 +61,7 @@ public void
createRestartStrategyFactory_fixedDelayRestartStrategyConfigured_ret
final Configuration configuration = new Configuration();
configuration.setString(RestartStrategyOptions.RESTART_STRATEGY, "fixed-delay");
configuration.setInteger(RestartStrategyOptions.RESTART_STRATEGY_FIXED_DELAY_ATTEMPTS,
attempts);
-
configuration.setString(RestartStrategyOptions.RESTART_STRATEGY_FIXED_DELAY_DELAY,
delayBetweenRestartAttempts.getSeconds() + "s");
+
configuration.setString(RestartStrategyOptions.RESTART_STRATEGY_FIXED_DELAY_DELAY.key(),
delayBetweenRestartAttempts.getSeconds() + "s");
Review comment:
Wondering whether we should just use a `Duration` here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
