dawidwys commented on a change in pull request #9433: [FLINK-13708]
[table-planner-blink] transformations should be cleared after execution in
blink planner
URL: https://github.com/apache/flink/pull/9433#discussion_r346886278
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/delegation/BatchPlanner.scala
##########
@@ -85,10 +86,14 @@ class BatchPlanner(
}
val optimizedRelNodes = optimize(sinkRelNodes)
val execNodes = translateToExecNodePlan(optimizedRelNodes)
- val transformations = translateToPlan(execNodes)
- val batchExecutor = new BatchExecutor(getExecEnv)
- batchExecutor.setTableConfig(getTableConfig)
- val streamGraph = batchExecutor.generateStreamGraph(transformations, "")
+
+ val plannerForExplain = createPlannerForExplain()
+ val transformations = translateToPlan(execNodes, plannerForExplain)
Review comment:
I think its unnecessary to change the signature of `translateToPlan` method.
Isn't it enought to call `plannerForExplain.translateToPlan(execNodes)`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
