KurtYoung commented on a change in pull request #10224:
[FLINK-14716][table-planner-blink] Cooperate computed column with push down
rules
URL: https://github.com/apache/flink/pull/10224#discussion_r347074734
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/schema/TableSourceTable.scala
##########
@@ -39,25 +45,39 @@ import scala.collection.JavaConverters._
* @param statistic The table statistics.
*/
class TableSourceTable[T](
+ relOptSchema: RelOptSchema,
+ names: JList[String],
+ rowType: RelDataType,
val tableSource: TableSource[T],
val isStreamingMode: Boolean,
- val statistic: FlinkStatistic,
+ statistic: FlinkStatistic,
val selectedFields: Option[Array[Int]],
Review comment:
This field should be useless. The only scenario this field might be used is
to determine row type of this table. But you already passed the `rowType` in
during constructor, I assume you already handle this projection before
constructing this table.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
