zhuzhurk opened a new pull request #10232: [FLINK-14314][runtime] Allocate shared slot resources respecting the resources of all vertices in the group URL: https://github.com/apache/flink/pull/10232 ## What is the purpose of the change With FLINK-14058, it is assumed that a shared slot should be large enough to be used by one instance of each JobVertex in the group simultaneously. This PR is to support it by allocate shared slot resources respecting the resources of all vertices in the slot sharing group. The Change is based on #10200. ## Brief change log 1. Add a physicalSlotResourceProfile in SlotProfile. If the task is not in a shared slot, it is the task resource profile. Otherwise it is the slot sharing group resource profile. It should be used for physical slot allocation. Rename previous ResourceProfile to be taskResourceProfile for logical slot allocation. 2. SharedSlotOversubscribedException and its handling can be removed, including part of the children slots releasing and re-allocating. This is because partial fulfillment should not happen anymore with #1. A simple sanity check can be kept for oversubscribing. ## Verifying this change This change added tests and can be verified as follows: - *Added unit tests for slot allocation regarding slot sharing resources* ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / **no**) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**) - The serializers: (yes / **no** / don't know) - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (**yes** / no / don't know) - The S3 file system connector: (yes / **no** / don't know) ## Documentation - Does this pull request introduce a new feature? (yes / **no**) - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
