dawidwys commented on a change in pull request #10059: [FLINK-14543][table]
Support partition for temporary table
URL: https://github.com/apache/flink/pull/10059#discussion_r347255182
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/descriptors/DescriptorProperties.java
##########
@@ -221,6 +225,18 @@ public void putTableSchema(String key, TableSchema
schema) {
}
}
+ /**
+ * Adds table partition keys.
+ */
+ public void putPartitionKeys(List<String> keys) {
Review comment:
I am not 100% sure if we need this method. This is a very local method. And
actually the only thing that this method does compared to
`putIndexedFixedProperties` is that it uses a fixed `PARTITION_KEYS` for the
key.
But I am fine with having it here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services