hequn8128 commented on a change in pull request #10061: [FLINK-14581][python]
Let python UDF execution no longer rely on the flink directory structure to
support running python UDFs on yarn.
URL: https://github.com/apache/flink/pull/10061#discussion_r347253021
##########
File path:
flink-python/src/main/java/org/apache/flink/client/python/PythonEnvUtils.java
##########
@@ -29,29 +28,22 @@
import java.io.File;
import java.io.IOException;
-import java.nio.file.FileSystems;
-import java.nio.file.FileVisitResult;
import java.nio.file.Files;
import java.nio.file.Paths;
-import java.nio.file.SimpleFileVisitor;
-import java.nio.file.attribute.BasicFileAttributes;
-import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.UUID;
import java.util.stream.Collectors;
+import static
org.apache.flink.python.util.ResourceUtil.extractBasicDependenciesFromResource;
+
/**
* The util class help to prepare Python env and run the python process.
*/
public final class PythonEnvUtils {
Review comment:
How about rename this Class to `PythonDriverEnvUtils `? I was confused when
seeing `extractBasicDependenciesFromResource` was also called here at first
glance.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
