klion26 commented on a change in pull request #10206: [FLINK-14781] [docs-zh]
clarify that a RocksDB dependency in pom.xml may not be needed
URL: https://github.com/apache/flink/pull/10206#discussion_r347304896
##########
File path: docs/ops/state/state_backends.zh.md
##########
@@ -155,7 +155,7 @@ env.setStateBackend(new
FsStateBackend("hdfs://namenode:40010/flink/checkpoints"
{% endhighlight %}
<div class="alert alert-info" markdown="span">
- <strong>注意:</strong> 由于 RocksDB 是 Flink 默认分发包的一部分，所以如果你没在代码中使用
RocksDB，那就不需要依赖它。而且可以在你的`flink-conf.yaml`文件中通过`state.backend`配置 state
backend，以及更多的 [checkpointing]({{ site.baseurl }}/ops/config.html#checkpointing)
和 [RocksDB 特定的]({{ site.baseurl }}/ops/config.html#rocksdb-state-backend) 参数。
+ <strong>注意:</strong> 由于 RocksDB 是 Flink 默认分发包的一部分，所以如果你没在代码中使用
RocksDB，则不需要添加此依赖。而且可以在 `flink-conf.yaml` 文件中通过 `state.backend` 配置 State
Backend，以及更多的 [checkpointing]({{ site.baseurl
}}/zh/ops/config.html#checkpointing) 和 [RocksDB 特定的]({{ site.baseurl
}}/zh/ops/config.html#rocksdb-state-backend) 参数。
Review comment:
the change here is good to me.
but, as the documentation has already mentioned that "rocksdb dependencly
may not be needed", and here we just correct the external link and some other
things, could we change the PR title and the issue title also?
I guess the translation is wrong here, I think the meaning here is that if
we do not configure the configuration, we do not need to add the dependency
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
