sunhaibotb commented on a change in pull request #10151: [FLINK-14231] Handle 
the processing-time timers before closing operator to properly support endInput
URL: https://github.com/apache/flink/pull/10151#discussion_r347365948
 
 

 ##########
 File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
 ##########
 @@ -205,6 +206,8 @@
 
        private Long syncSavepointId = null;
 
+       private final Map<StreamOperator<?>, ProcessingTimeServiceImpl> 
processingTimeServices;
 
 Review comment:
   > map key: Can we use OperatorID? StreamOperator is public interface and we 
know nothing about it's hashcode/equals (and we don't hold extra references to 
operators then)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to