Myasuka commented on a change in pull request #10230:
[FLINK-14803][metrics]Support Consistency Level for InfluxDB metrics
URL: https://github.com/apache/flink/pull/10230#discussion_r347542380
##########
File path:
flink-metrics/flink-metrics-influxdb/src/main/java/org/apache/flink/metrics/influxdb/InfluxdbReporterOptions.java
##########
@@ -57,6 +59,15 @@
.defaultValue("")
.withDescription("(optional) the InfluxDB retention policy for
metrics");
+ public static final ConfigOption<String> CONSISTENCY = ConfigOptions
Review comment:
I think Chensary would suggest to use `enumType` instead of current
`defaultValue` and the reason why you not generate docs is
because`InfluxdbReporterOptions` not included in
`org.apache.flink.docs.configuration.ConfigOptionsDocGenerator` currently.
Please refine current parameters description in docs if you decide to refer
to `Influxdb_reporter_coniguration.html`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
