docete commented on a change in pull request #10208:
[FLINK-11935][table-planner][table-planner-blink] Remove DateTimeUtils pull-in
and fix datetime casting problem
URL: https://github.com/apache/flink/pull/10208#discussion_r347696761
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/functions/SqlDateTimeUtils.java
##########
@@ -1297,4 +1297,10 @@ private static int parseFraction(String v, int
multiplier) {
return r;
}
+ // TODO: remove if CALCITE-3199 fixed
+ // https://issues.apache.org/jira/browse/CALCITE-3199
+ public static long unixDateCeil(TimeUnitRange range, long date) {
+ return julianDateFloor(range, (int) date + EPOCH_JULIAN, false);
Review comment:
the implementation of `Is this correct? It still calls
SqlDateTimeUtils#julianDateFloor` is different from `DateTimeutils`, but i
didn't find any bad case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
