KurtYoung commented on a change in pull request #10212:
[FLINK-14806][table-planner-blink] Add setTimestamp/getTimestamp inte…
URL: https://github.com/apache/flink/pull/10212#discussion_r347707661
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/dataformat/AbstractBinaryWriter.java
##########
@@ -181,6 +181,29 @@ public void writeDecimal(int pos, Decimal value, int
precision) {
}
}
+ @Override
+ public void writeTimestamp(int pos, SqlTimestamp value, int precision) {
+ if (SqlTimestamp.isCompact(precision)) {
+ assert 0 == value.getNanoOfMillisecond();
Review comment:
no need to assert here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
