dawidwys commented on a change in pull request #10217:
[FLINK-14786][configuration] Add configure method to ExecutionConfig
URL: https://github.com/apache/flink/pull/10217#discussion_r347784990
##########
File path: flink-core/src/main/java/org/apache/flink/api/common/time/Time.java
##########
@@ -81,7 +82,24 @@ public String toString() {
return toMilliseconds() + " ms";
}
- //
------------------------------------------------------------------------
+ @Override
Review comment:
The problem is that `RestartStrategies` implement `equals/hashcode` methods
that compare theirs `Time` fields. Because the `Time` class didn't have those
methods their implementation was wrong.
I found out about it during testing, don't know if it affects any production
code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
