dianfu commented on a change in pull request #10188: [FLINK-14066][python]
Support to install pyflink in windows
URL: https://github.com/apache/flink/pull/10188#discussion_r347785992
##########
File path: flink-python/setup.py
##########
@@ -108,8 +119,13 @@
print(incorrect_invocation_message, file=sys.stderr)
sys.exit(-1)
- if getattr(os, "symlink", None) is not None:
+ try:
Review comment:
There are cases the os support symlink however the disk doesn't support
symlink. This is found when we test this PR on a windows virtual machine in
which the disk is a mounted virtual disk.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
