zhuzhurk commented on a change in pull request #10237: [FLINK-14362][runtime]
Change DefaultSchedulingResultPartition to return correct partition state
URL: https://github.com/apache/flink/pull/10237#discussion_r347888603
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adapter/DefaultResultPartition.java
##########
@@ -42,17 +43,21 @@
private final ResultPartitionType partitionType;
+ private final Supplier<ResultPartitionState>
resultPartitionStateSupplier;
+
private DefaultExecutionVertex producer;
private final List<DefaultExecutionVertex> consumers;
DefaultResultPartition(
IntermediateResultPartitionID partitionId,
IntermediateDataSetID intermediateDataSetId,
- ResultPartitionType partitionType) {
+ ResultPartitionType partitionType,
+ Supplier<ResultPartitionState>
resultPartitionStateSupplier) {
Review comment:
Yes it's very similar.
Actually I'm thinking of simplifying the entire TestingSchedulingTopology
which is redundant since it is used to mock the jobVertex->executionVertex
structure of ExecutionGraph.
I think we can make it much simpler like `TestFailoverTopology`, which would
further make related tests simpler.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
